Compare commits

...

6 Commits

Author SHA1 Message Date
amir ec478531da v1.0.30: fix sync loop root causes + icon redesign
Three root causes found via live logcat on device:

1. concurrent refresh() race: onStartCommand received twice causes two
   refresh() coroutines to run in parallel, doubling FileObserver and
   catchupScan registrations. Fixed with Mutex.withLock on refresh().

2. catchupScan no cooldown: catchup syncs write files but never set
   syncCooldownUntil, so every written file immediately re-triggers
   onChangeDetected. Fixed by setting cooldown before enqueue and
   watching work completion same as onChangeDetected does.

3. CancellationException caught silently: exception handler
   catch(_: Exception) was catching CancellationException and resetting
   cooldown to 0L, re-opening the loop. Fixed by rethrowing
   CancellationException and setting 60s cooldown on other errors.

Icon: interlocked rings (blue/red/green/orange) with sync arrow at
center, pure black background — matches reference image.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-25 13:48:18 +00:00
amir 5ade80a334 v1.0.29: fix sync loop, stale-state auto-heal, icon redesign
- SyncEngine: self-healing stale folder state detection (isRetry) wipes
  orphaned SyncFileStateEntity records when localPath changes without a
  pair re-save — prevents repeated DELETE_REMOTE on 32 old files
- SyncEngine: second-precision mtime comparison (/ 1000 / .epochSecond)
  eliminates phantom localChanged=true from FAT32/WebDAV precision mismatch
- FileWatchService: syncCooldownUntil map suppresses FileObserver events
  for 120s after sync starts and 60s after it finishes, breaking the
  download→FileObserver→sync→download feedback loop
- Icon: three bold teardrop shapes (teal/red/amber) rotated 0/120/240°
  on dark charcoal background with white cloud at intersection

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-25 11:51:59 +00:00
amir 34fb06a673 v1.0.28: fix sync rewrite/delete loop, Avast-inspired icon
Sync loop root-cause fixes (three independent bugs):

1. Folder change clears stale file states (AddPairViewModel): when
   localPath or remotePath changes on an existing pair, all
   SyncFileStateEntity records are wiped. Previously those stale records
   caused every sync to attempt DELETE_REMOTE on the old folder's files
   and to treat all new-folder files as changed — causing both the
   "deleting 32 files" loop and rewrites on every run.

2. Download stores null localModifiedAt (SyncEngine): SAF document
   cursors can return a stale mtime immediately after a write. Storing
   null forces the SKIP reconciliation pass on the next sync to read
   the actual walkFiles cursor value, breaking the download->changed->
   download loop caused by mtime inconsistency.

3. Second-precision mtime comparison (syncDecide): WebDAV RFC-1123 has
   1-second precision; FAT32 has 2-second precision. Comparing at
   millisecond level caused phantom "changed" detections after syncing
   to/from these systems. Now uses epochSecond for both local and remote.

Icon: three bold teal/red/yellow teardrop streaks (Avast palette) flying
into a white cloud centre, on dark charcoal background.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-25 04:18:13 +00:00
amir dc2a0b2c68 v1.0.27: knot-inspired icon, fix media-not-found on photo open
Icon: two thick tube-style arcs with 3D glossy highlights.
  Arc 1 (left side): coral #E8665A to orange #E8A040
  Arc 2 (right side): steel blue #4A7FD4 to deep purple #7B5EA7
  Arrowheads: orange and purple. Background: dark purple-black.
  Inspired by the braided knot color palette.

Fix "media not found" when opening photos:
  - Intent now sets ClipData alongside FLAG_GRANT_READ_URI_PERMISSION
    so the permission correctly propagates through the system chooser
    to whichever app the user picks.
  - openFile() and downloadToCache() both call MediaScannerConnection
    so newly synced/downloaded files appear in gallery MediaStore index
    before the viewer launches.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-25 03:08:44 +00:00
amir 742f634084 v1.0.26: fix multi-selection reactivity, redesign icon, security review
Fix multi-selection: selectedKeys exposed as StateFlow, collected in
FilesScreen so checkboxes and highlights update correctly on every tap.
fileKey() made public so UI can check membership without ViewModel calls.

Icon: white cloud body with two cyan/teal circular sync arcs (AutoSync
style), deep blue-to-teal gradient background.

Security review clean: no hardcoded credentials, cleartext blocked by
network_security_config, allowBackup=false, path traversal guards in
place on both server responses and local resolution.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-25 02:45:43 +00:00
amir 8fdd22bc98 v1.0.25: multi-select files, unified notification, dark theme, icon redesign
- FilesScreen: long-press enters selection mode, bulk share/delete toolbar, BackHandler
- FilesViewModel: ShareMultiple action, isSelectionMode/selectedCount state, download-to-cache for open/share
- FileWatchService: recursive FileObserver per subdirectory; unified notification updated with sync result via WorkManager flow observation
- SyncWorker: silent flag suppresses notifications when triggered by watcher; emits KEY_RESULT_SUMMARY output data
- Passbolt-inspired dark theme (Red700/Red500 primary, near-black surface)
- App icon: circular AutoSync-style sync arrows (cyan gradient, deep navy background)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-25 02:22:43 +00:00
11 changed files with 529 additions and 243 deletions
@@ -62,13 +62,28 @@ class SyncEngine @Inject constructor(
else else
LocalAccessor.JavaFile(File(localPath)) LocalAccessor.JavaFile(File(localPath))
private suspend fun performSync(pair: SyncPair, provider: CloudProvider): SyncResult { private suspend fun performSync(
pair: SyncPair,
provider: CloudProvider,
isRetry: Boolean = false,
): SyncResult {
val accessor = makeAccessor(pair.localPath) val accessor = makeAccessor(pair.localPath)
val knownStates = fileStateDao.getForPair(pair.id).associateBy { it.relativePath } var knownStates = fileStateDao.getForPair(pair.id).associateBy { it.relativePath }
val remoteFiles = provider.listFiles(pair.remotePath).getOrThrow() val remoteFiles = provider.listFiles(pair.remotePath).getOrThrow()
.associateBy { it.path.removePrefix(pair.remotePath).trimStart('/') } .associateBy { it.path.removePrefix(pair.remotePath).trimStart('/') }
val localFiles = accessor.walkFiles(pair) val localFiles = accessor.walkFiles(pair)
// Self-healing: if every known-state path is absent from the current local scan but
// the local folder does have files, the localPath was changed without clearing state.
// The stale records would cause every old file to look like "DELETE_REMOTE" and every
// new file to re-upload indefinitely. Wipe and retry once as a fresh initial sync.
if (!isRetry && knownStates.isNotEmpty() && localFiles.isNotEmpty() &&
knownStates.keys.none { it in localFiles }) {
Timber.w("SyncEngine: stale folder states detected for pair ${pair.id} — resetting")
fileStateDao.deleteForPair(pair.id)
return performSync(pair, provider, isRetry = true)
}
val allPaths = (localFiles.keys + remoteFiles.keys + knownStates.keys).toSet() val allPaths = (localFiles.keys + remoteFiles.keys + knownStates.keys).toSet()
val hasPriorSyncState = knownStates.isNotEmpty() val hasPriorSyncState = knownStates.isNotEmpty()
val semaphore = Semaphore(4) val semaphore = Semaphore(4)
@@ -126,7 +141,9 @@ class SyncEngine @Inject constructor(
logEvent(pair.id, SyncEventType.FILE_DOWNLOADED, rel, null, bytes) logEvent(pair.id, SyncEventType.FILE_DOWNLOADED, rel, null, bytes)
FileOutcome(downloaded = 1, bytesTransferred = bytes, FileOutcome(downloaded = 1, bytesTransferred = bytes,
newState = buildState(pair.id, rel, newState = buildState(pair.id, rel,
LocalFileInfo(rel, remote!!.sizeBytes, localMtime), remoteAfterTransfer = remote)) LocalFileInfo(rel, remote!!.sizeBytes, localMtime),
remoteAfterTransfer = remote,
storeLocalMtime = false))
} }
SyncDecision.DELETE_LOCAL -> { SyncDecision.DELETE_LOCAL -> {
accessor.delete(rel) accessor.delete(rel)
@@ -203,10 +220,13 @@ class SyncEngine @Inject constructor(
rel: String, rel: String,
local: LocalFileInfo?, local: LocalFileInfo?,
remoteAfterTransfer: RemoteFile?, remoteAfterTransfer: RemoteFile?,
storeLocalMtime: Boolean = true,
) = SyncFileStateEntity( ) = SyncFileStateEntity(
syncPairId = pairId, syncPairId = pairId,
relativePath = rel, relativePath = rel,
localModifiedAt = local?.lastModifiedMs?.let { Instant.ofEpochMilli(it) }, // When storeLocalMtime=false, leave localModifiedAt null so the SKIP reconciliation
// pass on the next sync reads it from the walkFiles cursor (avoids SAF stale-mtime loops).
localModifiedAt = if (storeLocalMtime) local?.lastModifiedMs?.let { Instant.ofEpochMilli(it) } else null,
localSizeBytes = local?.sizeBytes ?: 0L, localSizeBytes = local?.sizeBytes ?: 0L,
localHash = null, localHash = null,
remoteModifiedAt = remoteAfterTransfer?.modifiedAt, remoteModifiedAt = remoteAfterTransfer?.modifiedAt,
@@ -236,12 +256,16 @@ internal fun syncDecide(
// Treat null known timestamps as "not yet recorded" — don't treat as changed. // Treat null known timestamps as "not yet recorded" — don't treat as changed.
// The SKIP reconciliation pass will fill them in on the next sync. // The SKIP reconciliation pass will fill them in on the next sync.
// Use second-precision for both sides: FAT32 has 2-second mtime resolution, WebDAV
// RFC-1123 has 1-second resolution, so millisecond comparison causes phantom "changed"
// detections and rewrite loops after a fresh download/upload.
val localChanged = known == null || val localChanged = known == null ||
(localExists && known.localModifiedAt != null && (localExists && known.localModifiedAt != null &&
local!!.lastModifiedMs != known.localModifiedAt.toEpochMilli()) local!!.lastModifiedMs / 1000 != known.localModifiedAt.epochSecond)
val remoteChanged = known == null || val remoteChanged = known == null ||
(remoteExists && known.remoteModifiedAt != null && (remoteExists && known.remoteModifiedAt != null &&
(remote!!.etag != known.remoteEtag || remote.modifiedAt != known.remoteModifiedAt)) (remote!!.etag != known.remoteEtag ||
remote.modifiedAt.epochSecond != known.remoteModifiedAt.epochSecond))
return when { return when {
!localExists && !remoteExists -> SyncDecision.SKIP !localExists && !remoteExists -> SyncDecision.SKIP
@@ -5,6 +5,7 @@ import androidx.lifecycle.SavedStateHandle
import androidx.lifecycle.ViewModel import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope import androidx.lifecycle.viewModelScope
import com.syncflow.data.db.CloudAccountDao import com.syncflow.data.db.CloudAccountDao
import com.syncflow.data.db.SyncFileStateDao
import com.syncflow.data.db.SyncPairDao import com.syncflow.data.db.SyncPairDao
import com.syncflow.data.db.entities.CloudAccountEntity import com.syncflow.data.db.entities.CloudAccountEntity
import com.syncflow.data.db.entities.SyncPairEntity import com.syncflow.data.db.entities.SyncPairEntity
@@ -58,6 +59,7 @@ data class AddPairUiState(
@HiltViewModel @HiltViewModel
class AddPairViewModel @Inject constructor( class AddPairViewModel @Inject constructor(
private val syncPairDao: SyncPairDao, private val syncPairDao: SyncPairDao,
private val fileStateDao: SyncFileStateDao,
private val accountDao: CloudAccountDao, private val accountDao: CloudAccountDao,
@ApplicationContext private val context: Context, @ApplicationContext private val context: Context,
savedState: SavedStateHandle, savedState: SavedStateHandle,
@@ -148,7 +150,20 @@ class AddPairViewModel @Inject constructor(
notifyOnComplete = s.notifyOnComplete, notifyOnError = s.notifyOnError, notifyOnComplete = s.notifyOnComplete, notifyOnError = s.notifyOnError,
isEnabled = true, lastSyncAt = null, lastSyncResult = SyncStatus.IDLE, pendingConflicts = 0, isEnabled = true, lastSyncAt = null, lastSyncResult = SyncStatus.IDLE, pendingConflicts = 0,
) )
if (editPairId == null) syncPairDao.insert(entity) else syncPairDao.update(entity) if (editPairId == null) {
syncPairDao.insert(entity)
} else {
val existing = syncPairDao.getById(editPairId)
syncPairDao.update(entity)
// If local or remote folder changed, old file-state records no longer
// correspond to any real path — wipe them so the next sync starts fresh
// instead of trying to delete/re-upload stale paths.
if (existing != null &&
(existing.localPath != entity.localPath || existing.remotePath != entity.remotePath)
) {
fileStateDao.deleteForPair(editPairId)
}
}
} }
.onSuccess { .onSuccess {
if (s.scheduleType == ScheduleType.ON_CHANGE) FileWatchService.start(context) if (s.scheduleType == ScheduleType.ON_CHANGE) FileWatchService.start(context)
@@ -1,7 +1,12 @@
package com.syncflow.ui.files package com.syncflow.ui.files
import android.content.ClipData
import android.content.Intent import android.content.Intent
import android.net.Uri
import android.webkit.MimeTypeMap import android.webkit.MimeTypeMap
import androidx.activity.compose.BackHandler
import androidx.compose.foundation.ExperimentalFoundationApi
import androidx.compose.foundation.combinedClickable
import androidx.compose.foundation.layout.* import androidx.compose.foundation.layout.*
import androidx.compose.foundation.lazy.LazyColumn import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items import androidx.compose.foundation.lazy.items
@@ -20,11 +25,12 @@ import androidx.core.content.FileProvider
import androidx.hilt.navigation.compose.hiltViewModel import androidx.hilt.navigation.compose.hiltViewModel
import com.syncflow.data.db.entities.SyncFileStateEntity import com.syncflow.data.db.entities.SyncFileStateEntity
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import java.io.File
import java.time.ZoneId import java.time.ZoneId
import java.time.format.DateTimeFormatter import java.time.format.DateTimeFormatter
import java.time.format.FormatStyle import java.time.format.FormatStyle
@OptIn(ExperimentalMaterial3Api::class) @OptIn(ExperimentalMaterial3Api::class, ExperimentalFoundationApi::class)
@Composable @Composable
fun FilesScreen( fun FilesScreen(
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
@@ -34,9 +40,15 @@ fun FilesScreen(
val selectedPair by vm.selectedPair.collectAsState() val selectedPair by vm.selectedPair.collectAsState()
val files by vm.files.collectAsState() val files by vm.files.collectAsState()
val isDownloading by vm.isDownloading.collectAsState() val isDownloading by vm.isDownloading.collectAsState()
val selectedKeys by vm.selectedKeys.collectAsState()
val isSelectionMode = selectedKeys.isNotEmpty()
val selectedCount = selectedKeys.size
val context = LocalContext.current val context = LocalContext.current
val snackbarHostState = remember { SnackbarHostState() } val snackbarHostState = remember { SnackbarHostState() }
val scope = rememberCoroutineScope() val scope = rememberCoroutineScope()
var showDeleteSelectedDialog by remember { mutableStateOf(false) }
BackHandler(enabled = isSelectionMode) { vm.clearSelection() }
LaunchedEffect(Unit) { LaunchedEffect(Unit) {
vm.fileAction.collect { action -> vm.fileAction.collect { action ->
@@ -46,15 +58,18 @@ fun FilesScreen(
val uri = FileProvider.getUriForFile( val uri = FileProvider.getUriForFile(
context, "${context.packageName}.fileprovider", action.file context, "${context.packageName}.fileprovider", action.file
) )
val mimeType = action.file.name.mimeType()
val intent = Intent(Intent.ACTION_VIEW).apply { val intent = Intent(Intent.ACTION_VIEW).apply {
setDataAndType(uri, action.file.name.mimeType()) setDataAndType(uri, mimeType)
addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION or Intent.FLAG_ACTIVITY_NEW_TASK) // ClipData is required so FLAG_GRANT_READ_URI_PERMISSION
} // propagates to whichever app the system chooser picks.
context.startActivity( clipData = ClipData.newRawUri("", uri)
Intent.createChooser(intent, "Open with").apply { addFlags(
addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) Intent.FLAG_GRANT_READ_URI_PERMISSION or
} Intent.FLAG_ACTIVITY_NEW_TASK
) )
}
context.startActivity(intent)
} catch (e: Exception) { } catch (e: Exception) {
snackbarHostState.showSnackbar("Cannot open file: ${e.message}") snackbarHostState.showSnackbar("Cannot open file: ${e.message}")
} }
@@ -67,6 +82,7 @@ fun FilesScreen(
val intent = Intent(Intent.ACTION_SEND).apply { val intent = Intent(Intent.ACTION_SEND).apply {
type = action.file.name.mimeType() type = action.file.name.mimeType()
putExtra(Intent.EXTRA_STREAM, uri) putExtra(Intent.EXTRA_STREAM, uri)
clipData = ClipData.newRawUri("", uri)
addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION or Intent.FLAG_ACTIVITY_NEW_TASK) addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION or Intent.FLAG_ACTIVITY_NEW_TASK)
} }
context.startActivity( context.startActivity(
@@ -78,6 +94,25 @@ fun FilesScreen(
snackbarHostState.showSnackbar("Cannot share file: ${e.message}") snackbarHostState.showSnackbar("Cannot share file: ${e.message}")
} }
} }
is FileAction.ShareMultiple -> {
try {
val uris = action.files.map { file ->
FileProvider.getUriForFile(context, "${context.packageName}.fileprovider", file)
}
val intent = Intent(Intent.ACTION_SEND_MULTIPLE).apply {
type = "*/*"
putParcelableArrayListExtra(Intent.EXTRA_STREAM, ArrayList(uris))
addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION or Intent.FLAG_ACTIVITY_NEW_TASK)
}
context.startActivity(
Intent.createChooser(intent, "Share files").apply {
addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
}
)
} catch (e: Exception) {
snackbarHostState.showSnackbar("Cannot share: ${e.message}")
}
}
is FileAction.Error -> scope.launch { is FileAction.Error -> scope.launch {
snackbarHostState.showSnackbar(action.message) snackbarHostState.showSnackbar(action.message)
} }
@@ -85,9 +120,62 @@ fun FilesScreen(
} }
} }
if (showDeleteSelectedDialog) {
AlertDialog(
onDismissRequest = { showDeleteSelectedDialog = false },
icon = { Icon(Icons.Default.Delete, contentDescription = null) },
title = { Text("Delete $selectedCount file${if (selectedCount != 1) "s" else ""}?") },
text = { Text("Selected files will be removed from this device.") },
confirmButton = {
TextButton(onClick = {
vm.deleteSelected()
showDeleteSelectedDialog = false
}) { Text("Delete", color = MaterialTheme.colorScheme.error) }
},
dismissButton = {
TextButton(onClick = { showDeleteSelectedDialog = false }) { Text("Cancel") }
},
)
}
Box(modifier = modifier.fillMaxSize()) { Box(modifier = modifier.fillMaxSize()) {
Column(modifier = Modifier.fillMaxSize()) { Column(modifier = Modifier.fillMaxSize()) {
if (pairs.size > 1) { // Selection toolbar
if (isSelectionMode) {
Surface(
color = MaterialTheme.colorScheme.primaryContainer,
tonalElevation = 3.dp,
) {
Row(
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 4.dp, vertical = 4.dp),
verticalAlignment = Alignment.CenterVertically,
) {
IconButton(onClick = { vm.clearSelection() }) {
Icon(Icons.Default.Close, contentDescription = "Clear selection")
}
Text(
"$selectedCount selected",
style = MaterialTheme.typography.titleSmall,
modifier = Modifier.weight(1f),
)
IconButton(onClick = { vm.shareSelected() }) {
Icon(Icons.Default.Share, contentDescription = "Share selected")
}
IconButton(onClick = { showDeleteSelectedDialog = true }) {
Icon(
Icons.Default.Delete, contentDescription = "Delete selected",
tint = MaterialTheme.colorScheme.error,
)
}
}
}
HorizontalDivider()
}
// Pair tabs
if (pairs.size > 1 && !isSelectionMode) {
ScrollableTabRow( ScrollableTabRow(
selectedTabIndex = pairs.indexOfFirst { it.id == selectedPair?.id }.coerceAtLeast(0), selectedTabIndex = pairs.indexOfFirst { it.id == selectedPair?.id }.coerceAtLeast(0),
edgePadding = 16.dp, edgePadding = 16.dp,
@@ -117,6 +205,7 @@ fun FilesScreen(
subtitle = "Run a sync to populate this view", subtitle = "Run a sync to populate this view",
) )
else -> { else -> {
if (!isSelectionMode) {
Surface(color = MaterialTheme.colorScheme.surfaceVariant.copy(alpha = 0.5f)) { Surface(color = MaterialTheme.colorScheme.surfaceVariant.copy(alpha = 0.5f)) {
Row( Row(
modifier = Modifier modifier = Modifier
@@ -137,6 +226,7 @@ fun FilesScreen(
) )
} }
} }
}
LazyColumn( LazyColumn(
contentPadding = PaddingValues(horizontal = 16.dp, vertical = 8.dp), contentPadding = PaddingValues(horizontal = 16.dp, vertical = 8.dp),
@@ -147,7 +237,7 @@ fun FilesScreen(
if (idx < 0) "" else f.relativePath.substring(0, idx) if (idx < 0) "" else f.relativePath.substring(0, idx)
} }
grouped.forEach { (dir, dirFiles) -> grouped.forEach { (dir, dirFiles) ->
if (dir.isNotEmpty()) { if (dir.isNotEmpty() && !isSelectionMode) {
item(key = "dir_$dir") { item(key = "dir_$dir") {
Row( Row(
modifier = Modifier.padding(top = 12.dp, bottom = 4.dp), modifier = Modifier.padding(top = 12.dp, bottom = 4.dp),
@@ -168,12 +258,16 @@ fun FilesScreen(
} }
} }
items(dirFiles, key = { "${it.syncPairId}_${it.relativePath}" }) { file -> items(dirFiles, key = { "${it.syncPairId}_${it.relativePath}" }) { file ->
FileRow(file = file, isInSubDir = dir.isNotEmpty(), vm = vm) FileRow(
file = file,
isInSubDir = dir.isNotEmpty() && !isSelectionMode,
isSelectionMode = isSelectionMode,
isSelected = vm.fileKey(file) in selectedKeys,
vm = vm,
)
HorizontalDivider( HorizontalDivider(
color = MaterialTheme.colorScheme.outline.copy(alpha = 0.25f), color = MaterialTheme.colorScheme.outline.copy(alpha = 0.25f),
modifier = Modifier.padding( modifier = Modifier.padding(start = if (dir.isNotEmpty() && !isSelectionMode) 38.dp else 16.dp),
start = if (dir.isNotEmpty()) 38.dp else 16.dp
),
) )
} }
} }
@@ -183,6 +277,7 @@ fun FilesScreen(
} }
} }
// Download progress
if (isDownloading) { if (isDownloading) {
Box( Box(
modifier = Modifier modifier = Modifier
@@ -237,8 +332,15 @@ private fun FilesEmptyState(icon: ImageVector, title: String, subtitle: String)
} }
} }
@OptIn(ExperimentalFoundationApi::class)
@Composable @Composable
private fun FileRow(file: SyncFileStateEntity, isInSubDir: Boolean, vm: FilesViewModel) { private fun FileRow(
file: SyncFileStateEntity,
isInSubDir: Boolean,
isSelectionMode: Boolean,
isSelected: Boolean,
vm: FilesViewModel,
) {
val name = file.relativePath.substringAfterLast('/') val name = file.relativePath.substringAfterLast('/')
val timeFmt = DateTimeFormatter.ofLocalizedDate(FormatStyle.SHORT) val timeFmt = DateTimeFormatter.ofLocalizedDate(FormatStyle.SHORT)
val syncedAt = file.lastSyncedAt.atZone(ZoneId.systemDefault()).let { timeFmt.format(it) } val syncedAt = file.lastSyncedAt.atZone(ZoneId.systemDefault()).let { timeFmt.format(it) }
@@ -250,10 +352,7 @@ private fun FileRow(file: SyncFileStateEntity, isInSubDir: Boolean, vm: FilesVie
if (showRenameDialog) { if (showRenameDialog) {
RenameDialog( RenameDialog(
currentName = name, currentName = name,
onConfirm = { newName -> onConfirm = { newName -> vm.renameFile(file, newName); showRenameDialog = false },
vm.renameFile(file, newName)
showRenameDialog = false
},
onDismiss = { showRenameDialog = false }, onDismiss = { showRenameDialog = false },
) )
} }
@@ -275,16 +374,34 @@ private fun FileRow(file: SyncFileStateEntity, isInSubDir: Boolean, vm: FilesVie
) )
} }
Row( Surface(
color = if (isSelected) MaterialTheme.colorScheme.primaryContainer.copy(alpha = 0.4f)
else MaterialTheme.colorScheme.surface,
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.padding( .combinedClickable(
onClick = {
if (isSelectionMode) vm.toggleSelection(file) else menuExpanded = true
},
onLongClick = { vm.toggleSelection(file) },
),
) {
Row(
modifier = Modifier.padding(
start = if (isInSubDir) 22.dp else 0.dp, start = if (isInSubDir) 22.dp else 0.dp,
top = 10.dp, top = 10.dp,
bottom = 10.dp, bottom = 10.dp,
end = 0.dp,
), ),
verticalAlignment = Alignment.CenterVertically, verticalAlignment = Alignment.CenterVertically,
) { ) {
if (isSelectionMode) {
Checkbox(
checked = isSelected,
onCheckedChange = { vm.toggleSelection(file) },
modifier = Modifier.padding(horizontal = 4.dp),
)
} else {
Surface( Surface(
shape = RoundedCornerShape(8.dp), shape = RoundedCornerShape(8.dp),
color = MaterialTheme.colorScheme.secondaryContainer, color = MaterialTheme.colorScheme.secondaryContainer,
@@ -299,6 +416,7 @@ private fun FileRow(file: SyncFileStateEntity, isInSubDir: Boolean, vm: FilesVie
} }
} }
Spacer(Modifier.width(12.dp)) Spacer(Modifier.width(12.dp))
}
Column(modifier = Modifier.weight(1f)) { Column(modifier = Modifier.weight(1f)) {
Text( Text(
name, name,
@@ -312,6 +430,7 @@ private fun FileRow(file: SyncFileStateEntity, isInSubDir: Boolean, vm: FilesVie
color = MaterialTheme.colorScheme.onSurfaceVariant, color = MaterialTheme.colorScheme.onSurfaceVariant,
) )
} }
if (!isSelectionMode) {
Box { Box {
IconButton(onClick = { menuExpanded = true }, modifier = Modifier.size(36.dp)) { IconButton(onClick = { menuExpanded = true }, modifier = Modifier.size(36.dp)) {
Icon( Icon(
@@ -323,27 +442,24 @@ private fun FileRow(file: SyncFileStateEntity, isInSubDir: Boolean, vm: FilesVie
DropdownMenu(expanded = menuExpanded, onDismissRequest = { menuExpanded = false }) { DropdownMenu(expanded = menuExpanded, onDismissRequest = { menuExpanded = false }) {
DropdownMenuItem( DropdownMenuItem(
text = { Text("Open") }, text = { Text("Open") },
leadingIcon = { Icon(Icons.Default.OpenInNew, contentDescription = null) }, leadingIcon = { Icon(Icons.Default.OpenInNew, null) },
onClick = { menuExpanded = false; vm.openFile(file) }, onClick = { menuExpanded = false; vm.openFile(file) },
) )
DropdownMenuItem( DropdownMenuItem(
text = { Text("Share") }, text = { Text("Share") },
leadingIcon = { Icon(Icons.Default.Share, contentDescription = null) }, leadingIcon = { Icon(Icons.Default.Share, null) },
onClick = { menuExpanded = false; vm.shareFile(file) }, onClick = { menuExpanded = false; vm.shareFile(file) },
) )
HorizontalDivider() HorizontalDivider()
DropdownMenuItem( DropdownMenuItem(
text = { Text("Rename") }, text = { Text("Rename") },
leadingIcon = { Icon(Icons.Default.Edit, contentDescription = null) }, leadingIcon = { Icon(Icons.Default.Edit, null) },
onClick = { menuExpanded = false; showRenameDialog = true }, onClick = { menuExpanded = false; showRenameDialog = true },
) )
DropdownMenuItem( DropdownMenuItem(
text = { Text("Delete", color = MaterialTheme.colorScheme.error) }, text = { Text("Delete", color = MaterialTheme.colorScheme.error) },
leadingIcon = { leadingIcon = {
Icon( Icon(Icons.Default.Delete, null, tint = MaterialTheme.colorScheme.error)
Icons.Default.Delete, contentDescription = null,
tint = MaterialTheme.colorScheme.error,
)
}, },
onClick = { menuExpanded = false; showDeleteDialog = true }, onClick = { menuExpanded = false; showDeleteDialog = true },
) )
@@ -351,13 +467,11 @@ private fun FileRow(file: SyncFileStateEntity, isInSubDir: Boolean, vm: FilesVie
} }
} }
} }
}
}
@Composable @Composable
private fun RenameDialog( private fun RenameDialog(currentName: String, onConfirm: (String) -> Unit, onDismiss: () -> Unit) {
currentName: String,
onConfirm: (String) -> Unit,
onDismiss: () -> Unit,
) {
var newName by remember { mutableStateOf(currentName) } var newName by remember { mutableStateOf(currentName) }
AlertDialog( AlertDialog(
onDismissRequest = onDismiss, onDismissRequest = onDismiss,
@@ -376,15 +490,12 @@ private fun RenameDialog(
TextButton( TextButton(
onClick = { onClick = {
val trimmed = newName.trim() val trimmed = newName.trim()
if (trimmed.isNotBlank() && trimmed != currentName) onConfirm(trimmed) if (trimmed.isNotBlank() && trimmed != currentName) onConfirm(trimmed) else onDismiss()
else onDismiss()
}, },
enabled = newName.isNotBlank(), enabled = newName.isNotBlank(),
) { Text("Rename") } ) { Text("Rename") }
}, },
dismissButton = { dismissButton = { TextButton(onClick = onDismiss) { Text("Cancel") } },
TextButton(onClick = onDismiss) { Text("Cancel") }
},
) )
} }
@@ -395,22 +506,16 @@ private fun String.mimeType(): String {
private fun fileIcon(name: String) = when { private fun fileIcon(name: String) = when {
name.endsWith(".pdf", ignoreCase = true) -> Icons.Default.PictureAsPdf name.endsWith(".pdf", ignoreCase = true) -> Icons.Default.PictureAsPdf
name.endsWith(".jpg", ignoreCase = true) || name.endsWith(".jpg", ignoreCase = true) || name.endsWith(".jpeg", ignoreCase = true) ||
name.endsWith(".jpeg", ignoreCase = true) || name.endsWith(".png", ignoreCase = true) || name.endsWith(".gif", ignoreCase = true) ||
name.endsWith(".png", ignoreCase = true) ||
name.endsWith(".gif", ignoreCase = true) ||
name.endsWith(".webp", ignoreCase = true) -> Icons.Default.Image name.endsWith(".webp", ignoreCase = true) -> Icons.Default.Image
name.endsWith(".mp4", ignoreCase = true) || name.endsWith(".mp4", ignoreCase = true) || name.endsWith(".mkv", ignoreCase = true) ||
name.endsWith(".mkv", ignoreCase = true) ||
name.endsWith(".mov", ignoreCase = true) -> Icons.Default.VideoFile name.endsWith(".mov", ignoreCase = true) -> Icons.Default.VideoFile
name.endsWith(".mp3", ignoreCase = true) || name.endsWith(".mp3", ignoreCase = true) || name.endsWith(".m4a", ignoreCase = true) ||
name.endsWith(".m4a", ignoreCase = true) ||
name.endsWith(".ogg", ignoreCase = true) -> Icons.Default.AudioFile name.endsWith(".ogg", ignoreCase = true) -> Icons.Default.AudioFile
name.endsWith(".zip", ignoreCase = true) || name.endsWith(".zip", ignoreCase = true) || name.endsWith(".tar", ignoreCase = true) ||
name.endsWith(".tar", ignoreCase = true) ||
name.endsWith(".gz", ignoreCase = true) -> Icons.Default.FolderZip name.endsWith(".gz", ignoreCase = true) -> Icons.Default.FolderZip
name.endsWith(".txt", ignoreCase = true) || name.endsWith(".txt", ignoreCase = true) || name.endsWith(".md", ignoreCase = true) -> Icons.Default.TextSnippet
name.endsWith(".md", ignoreCase = true) -> Icons.Default.TextSnippet
else -> Icons.Default.InsertDriveFile else -> Icons.Default.InsertDriveFile
} }
@@ -1,6 +1,7 @@
package com.syncflow.ui.files package com.syncflow.ui.files
import android.content.Context import android.content.Context
import android.media.MediaScannerConnection
import androidx.lifecycle.ViewModel import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope import androidx.lifecycle.viewModelScope
import com.syncflow.data.db.SyncFileStateDao import com.syncflow.data.db.SyncFileStateDao
@@ -14,6 +15,7 @@ import dagger.hilt.android.qualifiers.ApplicationContext
import kotlinx.coroutines.ExperimentalCoroutinesApi import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.flow.* import kotlinx.coroutines.flow.*
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import kotlinx.coroutines.flow.update
import timber.log.Timber import timber.log.Timber
import java.io.File import java.io.File
import javax.inject.Inject import javax.inject.Inject
@@ -21,6 +23,7 @@ import javax.inject.Inject
sealed class FileAction { sealed class FileAction {
data class Open(val file: File) : FileAction() data class Open(val file: File) : FileAction()
data class Share(val file: File) : FileAction() data class Share(val file: File) : FileAction()
data class ShareMultiple(val files: List<File>) : FileAction()
data class Error(val message: String) : FileAction() data class Error(val message: String) : FileAction()
} }
@@ -57,11 +60,20 @@ class FilesViewModel @Inject constructor(
private val _isDownloading = MutableStateFlow(false) private val _isDownloading = MutableStateFlow(false)
val isDownloading: StateFlow<Boolean> = _isDownloading val isDownloading: StateFlow<Boolean> = _isDownloading
private val _selectedKeys = MutableStateFlow<Set<String>>(emptySet())
val selectedKeys: StateFlow<Set<String>> = _selectedKeys
val isSelectionMode: StateFlow<Boolean> = _selectedKeys.map { it.isNotEmpty() }
.stateIn(viewModelScope, SharingStarted.WhileSubscribed(5_000), false)
val selectedCount: StateFlow<Int> = _selectedKeys.map { it.size }
.stateIn(viewModelScope, SharingStarted.WhileSubscribed(5_000), 0)
fun selectPair(id: Long) { _selectedPairId.value = id } fun selectPair(id: Long) { _selectedPairId.value = id }
fun openFile(file: SyncFileStateEntity) { fun openFile(file: SyncFileStateEntity) {
val resolved = resolveFile(file, emitErrorIfMissing = false) val resolved = resolveFile(file, emitErrorIfMissing = false)
if (resolved != null) { if (resolved != null) {
// Ensure MediaStore knows about this file so gallery apps can open it
MediaScannerConnection.scanFile(context, arrayOf(resolved.absolutePath), null, null)
viewModelScope.launch { _fileAction.emit(FileAction.Open(resolved)) } viewModelScope.launch { _fileAction.emit(FileAction.Open(resolved)) }
} else { } else {
downloadAndOpen(file) downloadAndOpen(file)
@@ -108,6 +120,44 @@ class FilesViewModel @Inject constructor(
} }
} }
fun isSelected(file: SyncFileStateEntity): Boolean = fileKey(file) in _selectedKeys.value
fun toggleSelection(file: SyncFileStateEntity) {
val key = fileKey(file)
_selectedKeys.update { if (key in it) it - key else it + key }
}
fun clearSelection() { _selectedKeys.value = emptySet() }
fun deleteSelected() {
viewModelScope.launch {
val toDelete = files.value.filter { isSelected(it) }
toDelete.forEach { file ->
try {
resolveFile(file, emitErrorIfMissing = false)?.delete()
fileStateDao.delete(file.syncPairId, file.relativePath)
} catch (e: Exception) {
Timber.e(e, "Bulk delete failed: ${file.relativePath}")
}
}
clearSelection()
}
}
fun shareSelected() {
viewModelScope.launch {
val toShare = files.value.filter { isSelected(it) }
val resolved = toShare.mapNotNull { resolveFile(it, emitErrorIfMissing = false) }
if (resolved.isEmpty()) {
_fileAction.emit(FileAction.Error("No local files available to share"))
return@launch
}
_fileAction.emit(FileAction.ShareMultiple(resolved))
}
}
fun fileKey(file: SyncFileStateEntity) = "${file.syncPairId}:${file.relativePath}"
// ── Download-then-open/share ────────────────────────────────────────────── // ── Download-then-open/share ──────────────────────────────────────────────
private fun downloadAndOpen(file: SyncFileStateEntity) { private fun downloadAndOpen(file: SyncFileStateEntity) {
@@ -145,6 +195,7 @@ class FilesViewModel @Inject constructor(
cacheFile.outputStream().use { out -> cacheFile.outputStream().use { out ->
provider.downloadFile("${pair.remotePath}/${file.relativePath}", out) { }.getOrThrow() provider.downloadFile("${pair.remotePath}/${file.relativePath}", out) { }.getOrThrow()
} }
MediaScannerConnection.scanFile(context, arrayOf(cacheFile.absolutePath), null, null)
cacheFile cacheFile
} catch (e: Exception) { } catch (e: Exception) {
Timber.e(e, "Download for preview failed: ${file.relativePath}") Timber.e(e, "Download for preview failed: ${file.relativePath}")
@@ -2,27 +2,28 @@ package com.syncflow.ui.theme
import androidx.compose.ui.graphics.Color import androidx.compose.ui.graphics.Color
// Primary — indigo // Primary — deep red (Passbolt-inspired)
val Indigo600 = Color(0xFF4F46E5) val Red900 = Color(0xFF7F0000)
val Indigo900 = Color(0xFF312E81) val Red700 = Color(0xFFB71C1C)
val Indigo100 = Color(0xFFE0E7FF) val Red500 = Color(0xFFEF5350)
val Indigo50 = Color(0xFFEEF2FF) val Red100 = Color(0xFFFFCDD2)
val Red50 = Color(0xFFFFEBEE)
// Secondary — teal // Secondary — deep orange
val Teal600 = Color(0xFF0D9488) val Orange700 = Color(0xFFE64A19)
val Teal100 = Color(0xFFCCFBF1) val Orange100 = Color(0xFFFBE9E7)
// Tertiary — amber // Tertiary — amber
val Amber500 = Color(0xFFF59E0B) val Amber500 = Color(0xFFFFB300)
val Amber100 = Color(0xFFFEF3C7) val Amber100 = Color(0xFFFFF8E1)
// Neutrals // Neutrals
val Slate50 = Color(0xFFF8FAFC) val Gray50 = Color(0xFFF8F9FA)
val Slate100 = Color(0xFFF1F5F9) val Gray100 = Color(0xFFF3F4F6)
val Slate200 = Color(0xFFE2E8F0) val Gray200 = Color(0xFFE5E7EB)
val Slate600 = Color(0xFF475569) val Gray600 = Color(0xFF6B7280)
val Slate900 = Color(0xFF0F172A) val Gray900 = Color(0xFF111827)
// Semantic // Semantic
val GreenSuccess = Color(0xFF16A34A) val GreenSuccess = Color(0xFF2E7D32)
val RedError = Color(0xFFDC2626) val RedError = Color(0xFFEF5350)
@@ -13,41 +13,43 @@ import androidx.compose.ui.unit.sp
import androidx.core.view.WindowCompat import androidx.core.view.WindowCompat
private val LightColors = lightColorScheme( private val LightColors = lightColorScheme(
primary = Indigo600, primary = Red700,
onPrimary = Color.White, onPrimary = Color.White,
primaryContainer = Indigo100, primaryContainer = Red50,
onPrimaryContainer = Indigo900, onPrimaryContainer = Red900,
secondary = Teal600, secondary = Orange700,
onSecondary = Color.White, onSecondary = Color.White,
secondaryContainer = Teal100, secondaryContainer = Orange100,
tertiary = Amber500, tertiary = Amber500,
tertiaryContainer = Amber100, tertiaryContainer = Amber100,
background = Slate50, background = Gray50,
surface = Color.White, surface = Color.White,
surfaceVariant = Slate100, surfaceVariant = Gray100,
onSurfaceVariant = Slate600, onSurface = Gray900,
onSurfaceVariant = Gray600,
error = RedError, error = RedError,
errorContainer = Color(0xFFFEE2E2), errorContainer = Red50,
outline = Slate200, outline = Gray200,
) )
private val DarkColors = darkColorScheme( private val DarkColors = darkColorScheme(
primary = Color(0xFF818CF8), primary = Red500,
onPrimary = Indigo900, onPrimary = Color.White,
primaryContainer = Color(0xFF3730A3), primaryContainer = Red900,
onPrimaryContainer = Indigo100, onPrimaryContainer = Red100,
secondary = Color(0xFF2DD4BF), secondary = Color(0xFFFF7043),
onSecondary = Color(0xFF003731), onSecondary = Color.White,
secondaryContainer = Color(0xFF00504A), secondaryContainer = Color(0xFF4E1500),
tertiary = Amber500, tertiary = Amber500,
tertiaryContainer = Color(0xFF92400E), tertiaryContainer = Color(0xFF3E2700),
background = Color(0xFF0F0F1A), background = Color(0xFF0F0F0F),
surface = Color(0xFF1A1A2E), surface = Color(0xFF1C1C1C),
surfaceVariant = Color(0xFF252538), surfaceVariant = Color(0xFF2A2A2A),
onSurfaceVariant = Color(0xFF94A3B8), onSurface = Color(0xFFEAEAEA),
error = Color(0xFFF87171), onSurfaceVariant = Color(0xFF9E9E9E),
errorContainer = Color(0xFF7F1D1D), error = Color(0xFFFF5252),
outline = Color(0xFF334155), errorContainer = Color(0xFF5C0000),
outline = Color(0xFF3D3D3D),
) )
private val AppTypography = Typography( private val AppTypography = Typography(
@@ -13,7 +13,9 @@ import android.os.Looper
import android.provider.DocumentsContract import android.provider.DocumentsContract
import androidx.core.app.NotificationCompat import androidx.core.app.NotificationCompat
import androidx.work.ExistingWorkPolicy import androidx.work.ExistingWorkPolicy
import androidx.work.WorkInfo
import androidx.work.WorkManager import androidx.work.WorkManager
import kotlinx.coroutines.flow.first
import com.syncflow.MainActivity import com.syncflow.MainActivity
import com.syncflow.R import com.syncflow.R
import com.syncflow.data.db.SyncFileStateDao import com.syncflow.data.db.SyncFileStateDao
@@ -21,6 +23,8 @@ import com.syncflow.data.db.SyncPairDao
import com.syncflow.domain.model.ScheduleType import com.syncflow.domain.model.ScheduleType
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.* import kotlinx.coroutines.*
import kotlinx.coroutines.sync.Mutex
import kotlinx.coroutines.sync.withLock
import timber.log.Timber import timber.log.Timber
import java.io.File import java.io.File
import javax.inject.Inject import javax.inject.Inject
@@ -33,11 +37,16 @@ class FileWatchService : Service() {
private val scope = CoroutineScope(Dispatchers.IO + SupervisorJob()) private val scope = CoroutineScope(Dispatchers.IO + SupervisorJob())
private val mainHandler = Handler(Looper.getMainLooper()) private val mainHandler = Handler(Looper.getMainLooper())
// Prevents concurrent refresh() calls from doubling watchers + catchup scans
private val refreshMutex = Mutex()
// Multiple FileObserver instances per pair: one per directory (recursive) // Multiple FileObserver instances per pair: one per directory (recursive)
private val fileObservers = mutableMapOf<Long, MutableList<FileObserver>>() private val fileObservers = mutableMapOf<Long, MutableList<FileObserver>>()
private val contentObservers = mutableMapOf<Long, ContentObserver>() private val contentObservers = mutableMapOf<Long, ContentObserver>()
private val debounceJobs = mutableMapOf<Long, Job>() private val debounceJobs = mutableMapOf<Long, Job>()
// After a watcher-triggered sync completes, suppress FileObserver events for this long
// to stop the feedback loop: sync writes files → FileObserver fires → another sync → repeat.
private val syncCooldownUntil = mutableMapOf<Long, Long>()
companion object { companion object {
const val CHANNEL_WATCH = "sync_watching" const val CHANNEL_WATCH = "sync_watching"
@@ -76,7 +85,7 @@ class FileWatchService : Service() {
override fun onBind(intent: Intent?): IBinder? = null override fun onBind(intent: Intent?): IBinder? = null
private suspend fun refresh() { private suspend fun refresh() = refreshMutex.withLock {
clearWatchers() clearWatchers()
val pairs = syncPairDao.getEnabled().filter { it.scheduleType == ScheduleType.ON_CHANGE } val pairs = syncPairDao.getEnabled().filter { it.scheduleType == ScheduleType.ON_CHANGE }
@@ -198,25 +207,74 @@ class FileWatchService : Service() {
if (hasNew || hasModified || hasDeleted) { if (hasNew || hasModified || hasDeleted) {
Timber.d("FileWatchService: catchup detected changes for pair $pairId, scheduling sync") Timber.d("FileWatchService: catchup detected changes for pair $pairId, scheduling sync")
val pair = syncPairDao.getById(pairId) ?: return val pair = syncPairDao.getById(pairId) ?: return
// Set cooldown so file writes during this sync don't immediately re-trigger
syncCooldownUntil[pairId] = System.currentTimeMillis() + 120_000
val req = SyncWorker.buildOneTimeRequest(pairId, wifiOnly, chargingOnly)
WorkManager.getInstance(applicationContext) WorkManager.getInstance(applicationContext)
.enqueueUniqueWork( .enqueueUniqueWork("catchup_$pairId", ExistingWorkPolicy.KEEP, req)
"catchup_$pairId", scope.launch {
ExistingWorkPolicy.KEEP, try {
SyncWorker.buildOneTimeRequest(pairId, wifiOnly, chargingOnly), WorkManager.getInstance(applicationContext)
) .getWorkInfoByIdFlow(req.id)
.first { it?.state?.isFinished == true }
syncCooldownUntil[pairId] = System.currentTimeMillis() + 60_000
} catch (e: CancellationException) {
throw e
} catch (_: Exception) {
syncCooldownUntil[pairId] = System.currentTimeMillis() + 60_000
}
}
} }
} }
private fun onChangeDetected(pairId: Long, wifiOnly: Boolean, chargingOnly: Boolean) { private fun onChangeDetected(pairId: Long, wifiOnly: Boolean, chargingOnly: Boolean) {
// Ignore events fired by our own sync writing files — prevents the feedback loop
// where downloaded/uploaded files trigger another sync indefinitely.
if (System.currentTimeMillis() < (syncCooldownUntil[pairId] ?: 0L)) {
Timber.d("FileWatchService: suppressing change event for pair $pairId (sync cooldown)")
return
}
debounceJobs[pairId]?.cancel() debounceJobs[pairId]?.cancel()
debounceJobs[pairId] = scope.launch { debounceJobs[pairId] = scope.launch {
delay(5_000) delay(5_000)
val pair = syncPairDao.getById(pairId) val pair = syncPairDao.getById(pairId)
if (pair == null || !pair.isEnabled) return@launch if (pair == null || !pair.isEnabled) return@launch
Timber.d("FileWatchService: triggering sync for pair $pairId after debounce") Timber.d("FileWatchService: triggering sync for pair $pairId after debounce")
val req = SyncWorker.buildOneTimeRequest(pairId, wifiOnly, chargingOnly)
// Block new triggers from this point until 60s after sync completes
syncCooldownUntil[pairId] = System.currentTimeMillis() + 120_000
val req = SyncWorker.buildOneTimeRequest(pairId, wifiOnly, chargingOnly, silent = true)
WorkManager.getInstance(applicationContext) WorkManager.getInstance(applicationContext)
.enqueueUniqueWork("onchange_$pairId", ExistingWorkPolicy.KEEP, req) .enqueueUniqueWork("onchange_$pairId", ExistingWorkPolicy.KEEP, req)
updateNotificationDynamic("Syncing: ${pair.name}")
scope.launch {
try {
val info = WorkManager.getInstance(applicationContext)
.getWorkInfoByIdFlow(req.id)
.first { it?.state?.isFinished == true }
// Extend cooldown: 60s after sync finishes to let filesystem settle
syncCooldownUntil[pairId] = System.currentTimeMillis() + 60_000
val summary = info?.outputData?.getString(SyncWorker.KEY_RESULT_SUMMARY)
val watchCount = fileObservers.keys.size + contentObservers.size
val watching = "Watching $watchCount folder${if (watchCount != 1) "s" else ""}"
if (info?.state == WorkInfo.State.SUCCEEDED && summary != null) {
updateNotificationDynamic("${pair.name}: $summary$watching")
} else {
updateNotificationDynamic("$watching")
}
delay(12_000)
updateNotificationDynamic(null)
} catch (e: CancellationException) {
throw e
} catch (_: Exception) {
syncCooldownUntil[pairId] = System.currentTimeMillis() + 60_000
updateNotificationDynamic(null)
}
}
} }
} }
@@ -227,6 +285,7 @@ class FileWatchService : Service() {
contentObservers.clear() contentObservers.clear()
debounceJobs.values.forEach { it.cancel() } debounceJobs.values.forEach { it.cancel() }
debounceJobs.clear() debounceJobs.clear()
syncCooldownUntil.clear()
} }
private fun ensureChannel() { private fun ensureChannel() {
@@ -241,7 +300,7 @@ class FileWatchService : Service() {
} }
} }
private fun buildNotification(count: Int): Notification { private fun buildNotification(count: Int, overrideText: String? = null): Notification {
val tapIntent = PendingIntent.getActivity( val tapIntent = PendingIntent.getActivity(
this, 0, this, 0,
Intent(this, MainActivity::class.java).apply { flags = Intent.FLAG_ACTIVITY_SINGLE_TOP }, Intent(this, MainActivity::class.java).apply { flags = Intent.FLAG_ACTIVITY_SINGLE_TOP },
@@ -250,7 +309,7 @@ class FileWatchService : Service() {
return NotificationCompat.Builder(this, CHANNEL_WATCH) return NotificationCompat.Builder(this, CHANNEL_WATCH)
.setContentTitle("SyncFlow") .setContentTitle("SyncFlow")
.setContentText( .setContentText(
if (count > 0) "Watching $count folder${if (count != 1) "s" else ""} for changes" overrideText ?: if (count > 0) "Watching $count folder${if (count != 1) "s" else ""} for changes"
else "Starting file watcher…" else "Starting file watcher…"
) )
.setSmallIcon(R.drawable.ic_sync) .setSmallIcon(R.drawable.ic_sync)
@@ -264,4 +323,10 @@ class FileWatchService : Service() {
val nm = getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager val nm = getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
nm.notify(NOTIFICATION_ID, buildNotification(count)) nm.notify(NOTIFICATION_ID, buildNotification(count))
} }
private fun updateNotificationDynamic(overrideText: String?) {
val count = fileObservers.keys.size + contentObservers.size
val nm = getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
nm.notify(NOTIFICATION_ID, buildNotification(count, overrideText))
}
} }
@@ -39,6 +39,8 @@ class SyncWorker @AssistedInject constructor(
val pair = syncPairDao.getById(pairId) ?: return Result.failure() val pair = syncPairDao.getById(pairId) ?: return Result.failure()
val account = accountRepository.getAccount(pair.accountId) ?: return Result.failure() val account = accountRepository.getAccount(pair.accountId) ?: return Result.failure()
val silent = inputData.getBoolean(KEY_SILENT, false)
ensureChannels() ensureChannels()
setForeground(buildForegroundInfo(pair.name, "Syncing…")) setForeground(buildForegroundInfo(pair.name, "Syncing…"))
@@ -47,7 +49,15 @@ class SyncWorker @AssistedInject constructor(
val provider = providerFactory.create(account) val provider = providerFactory.create(account)
val result = syncEngine.sync(domainPair, provider) val result = syncEngine.sync(domainPair, provider)
if (result.error != null && pair.notifyOnError) { val lines = buildList {
if (result.uploaded > 0) add("${result.uploaded}")
if (result.downloaded > 0) add("${result.downloaded}")
if (result.deleted > 0) add("🗑${result.deleted}")
if (result.conflicts > 0) add("${result.conflicts}")
}
val resultSummary = if (lines.isEmpty()) "Up to date" else lines.joinToString(" ")
if (!silent && result.error != null && pair.notifyOnError) {
notify( notify(
id = pairId.toInt() + RESULT_ID_OFFSET, id = pairId.toInt() + RESULT_ID_OFFSET,
channelId = CHANNEL_ALERTS, channelId = CHANNEL_ALERTS,
@@ -55,28 +65,28 @@ class SyncWorker @AssistedInject constructor(
text = result.error.message ?: "Unknown error", text = result.error.message ?: "Unknown error",
priority = NotificationCompat.PRIORITY_DEFAULT, priority = NotificationCompat.PRIORITY_DEFAULT,
) )
} else if (pair.notifyOnComplete && result.error == null) { } else if (!silent && pair.notifyOnComplete && result.error == null) {
val lines = buildList { val fullLines = buildList {
if (result.uploaded > 0) add("↑ Uploaded: ${result.uploaded} file${if (result.uploaded != 1) "s" else ""}") if (result.uploaded > 0) add("↑ Uploaded: ${result.uploaded} file${if (result.uploaded != 1) "s" else ""}")
if (result.downloaded > 0) add("↓ Downloaded: ${result.downloaded} file${if (result.downloaded != 1) "s" else ""}") if (result.downloaded > 0) add("↓ Downloaded: ${result.downloaded} file${if (result.downloaded != 1) "s" else ""}")
if (result.deleted > 0) add("🗑 Deleted: ${result.deleted} file${if (result.deleted != 1) "s" else ""}") if (result.deleted > 0) add("🗑 Deleted: ${result.deleted} file${if (result.deleted != 1) "s" else ""}")
if (result.conflicts > 0) add("${result.conflicts} conflict${if (result.conflicts != 1) "s" else ""}") if (result.conflicts > 0) add("${result.conflicts} conflict${if (result.conflicts != 1) "s" else ""}")
} }
val summary = if (lines.isEmpty()) "Up to date — nothing to sync" else lines.joinToString("\n") val summary = if (fullLines.isEmpty()) "Up to date — nothing to sync" else fullLines.joinToString("\n")
notify( notify(
id = pairId.toInt() + RESULT_ID_OFFSET, id = pairId.toInt() + RESULT_ID_OFFSET,
channelId = CHANNEL_COMPLETE, channelId = CHANNEL_COMPLETE,
title = "${pair.name}Changes synced", title = "${pair.name}Synced",
text = if (lines.isEmpty()) summary else lines.first(), text = if (fullLines.isEmpty()) summary else fullLines.first(),
bigText = summary, bigText = summary,
priority = NotificationCompat.PRIORITY_LOW, priority = NotificationCompat.PRIORITY_LOW,
) )
} }
Result.success() Result.success(workDataOf(KEY_RESULT_SUMMARY to resultSummary))
} catch (e: Exception) { } catch (e: Exception) {
Timber.e(e, "SyncWorker failed for pair $pairId") Timber.e(e, "SyncWorker failed for pair $pairId")
if (pair.notifyOnError) { if (!silent && pair.notifyOnError) {
notify( notify(
id = pairId.toInt() + RESULT_ID_OFFSET, id = pairId.toInt() + RESULT_ID_OFFSET,
channelId = CHANNEL_ALERTS, channelId = CHANNEL_ALERTS,
@@ -146,19 +156,21 @@ class SyncWorker @AssistedInject constructor(
companion object { companion object {
const val KEY_PAIR_ID = "pair_id" const val KEY_PAIR_ID = "pair_id"
const val KEY_SILENT = "silent"
const val KEY_RESULT_SUMMARY = "result_summary"
private const val NOTIFICATION_ID = 1001 private const val NOTIFICATION_ID = 1001
private const val RESULT_ID_OFFSET = 2000 private const val RESULT_ID_OFFSET = 2000
private const val CHANNEL_PROGRESS = "sync_progress" private const val CHANNEL_PROGRESS = "sync_progress"
private const val CHANNEL_COMPLETE = "sync_complete" private const val CHANNEL_COMPLETE = "sync_complete"
private const val CHANNEL_ALERTS = "sync_alerts" private const val CHANNEL_ALERTS = "sync_alerts"
fun buildOneTimeRequest(pairId: Long, wifiOnly: Boolean, chargingOnly: Boolean): OneTimeWorkRequest { fun buildOneTimeRequest(pairId: Long, wifiOnly: Boolean, chargingOnly: Boolean, silent: Boolean = false): OneTimeWorkRequest {
val constraints = Constraints.Builder() val constraints = Constraints.Builder()
.setRequiredNetworkType(if (wifiOnly) NetworkType.UNMETERED else NetworkType.CONNECTED) .setRequiredNetworkType(if (wifiOnly) NetworkType.UNMETERED else NetworkType.CONNECTED)
.setRequiresCharging(chargingOnly) .setRequiresCharging(chargingOnly)
.build() .build()
return OneTimeWorkRequestBuilder<SyncWorker>() return OneTimeWorkRequestBuilder<SyncWorker>()
.setInputData(workDataOf(KEY_PAIR_ID to pairId)) .setInputData(workDataOf(KEY_PAIR_ID to pairId, KEY_SILENT to silent))
.setConstraints(constraints) .setConstraints(constraints)
.setBackoffCriteria(BackoffPolicy.EXPONENTIAL, 30, TimeUnit.SECONDS) .setBackoffCriteria(BackoffPolicy.EXPONENTIAL, 30, TimeUnit.SECONDS)
.addTag("sync_$pairId") .addTag("sync_$pairId")
@@ -1,11 +1,12 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<shape xmlns:android="http://schemas.android.com/apk/res/android"> <vector xmlns:android="http://schemas.android.com/apk/res/android"
<gradient android:width="108dp"
android:type="radial" android:height="108dp"
android:gradientRadius="80%" android:viewportWidth="108"
android:centerX="0.35" android:viewportHeight="108">
android:centerY="0.3"
android:startColor="#1C1124" <!-- Pure black background -->
android:centerColor="#0E0A18" <path android:pathData="M0,0 H108 V108 H0 Z"
android:endColor="#060408"/> android:fillColor="#000000"/>
</shape>
</vector>
@@ -1,66 +1,76 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<vector xmlns:android="http://schemas.android.com/apk/res/android" <vector xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:aapt="http://schemas.android.com/aapt"
android:width="108dp" android:width="108dp"
android:height="108dp" android:height="108dp"
android:viewportWidth="108" android:viewportWidth="108"
android:viewportHeight="108"> android:viewportHeight="108">
<!-- <!--
Three identical arcs pointing right, evenly spaced vertically. Four interlocked ring arcs (blue/red/green/orange), each a thick rounded band
Same curve shape, same gradient direction, same arrowhead geometry — purely harmonious. arranged in a 2x2 offset so they interweave. A white sync-arrow circle sits
Control point 14dp above midline on each arc. at the center. Designed to match the braided-knot reference icon.
--> -->
<!-- Arc 1 — top --> <!-- Blue ring - top-left -->
<path <path
android:pathData="M 26,34 Q 54,20 82,34" android:strokeColor="#2979FF"
android:strokeWidth="7"
android:fillColor="#00000000" android:fillColor="#00000000"
android:strokeWidth="8.5"
android:strokeLineCap="round" android:strokeLineCap="round"
android:strokeLineJoin="round"> android:pathData="M 38,36
<aapt:attr name="android:strokeColor"> A 16,16 0 1,1 54,52
<gradient android:type="linear" A 16,16 0 1,1 38,36 Z"/>
android:startX="26" android:startY="34"
android:endX="82" android:endY="34"
android:startColor="#64C8FF"
android:endColor="#32EDBB"/>
</aapt:attr>
</path>
<path android:pathData="M 77.5,27.3 L 82,34 L 74.0,34.5 Z" android:fillColor="#32EDBB"/>
<!-- Arc 2 — middle --> <!-- Red ring - top-right -->
<path <path
android:pathData="M 26,54 Q 54,40 82,54" android:strokeColor="#F44336"
android:strokeWidth="7"
android:fillColor="#00000000" android:fillColor="#00000000"
android:strokeWidth="8.5"
android:strokeLineCap="round" android:strokeLineCap="round"
android:strokeLineJoin="round"> android:pathData="M 54,36
<aapt:attr name="android:strokeColor"> A 16,16 0 1,1 70,52
<gradient android:type="linear" A 16,16 0 1,1 54,36 Z"/>
android:startX="26" android:startY="54"
android:endX="82" android:endY="54"
android:startColor="#64C8FF"
android:endColor="#32EDBB"/>
</aapt:attr>
</path>
<path android:pathData="M 77.5,47.3 L 82,54 L 74.0,54.5 Z" android:fillColor="#32EDBB"/>
<!-- Arc 3 — bottom --> <!-- Green ring - bottom-left -->
<path <path
android:pathData="M 26,74 Q 54,60 82,74" android:strokeColor="#00C853"
android:strokeWidth="7"
android:fillColor="#00000000" android:fillColor="#00000000"
android:strokeWidth="8.5"
android:strokeLineCap="round" android:strokeLineCap="round"
android:strokeLineJoin="round"> android:pathData="M 38,52
<aapt:attr name="android:strokeColor"> A 16,16 0 1,1 54,68
<gradient android:type="linear" A 16,16 0 1,1 38,52 Z"/>
android:startX="26" android:startY="74"
android:endX="82" android:endY="74" <!-- Orange ring - bottom-right -->
android:startColor="#64C8FF" <path
android:endColor="#32EDBB"/> android:strokeColor="#FF6D00"
</aapt:attr> android:strokeWidth="7"
</path> android:fillColor="#00000000"
<path android:pathData="M 77.5,67.3 L 82,74 L 74.0,74.5 Z" android:fillColor="#32EDBB"/> android:strokeLineCap="round"
android:pathData="M 54,52
A 16,16 0 1,1 70,68
A 16,16 0 1,1 54,52 Z"/>
<!-- White filled circle at center to create interlock illusion -->
<path
android:fillColor="#000000"
android:pathData="M 46,52 A 8,8 0 1,0 62,52 A 8,8 0 1,0 46,52 Z"/>
<!-- Sync arrow ring (outer white circle) -->
<path
android:strokeColor="#FFFFFF"
android:strokeWidth="3.5"
android:fillColor="#00000000"
android:pathData="M 47,52 A 7,7 0 1,0 61,52 A 7,7 0 1,0 47,52 Z"/>
<!-- Sync arrow head top -->
<path
android:fillColor="#FFFFFF"
android:pathData="M 54,45 L 57,49 L 51,49 Z"/>
<!-- Sync arrow head bottom -->
<path
android:fillColor="#FFFFFF"
android:pathData="M 54,59 L 51,55 L 57,55 Z"/>
</vector> </vector>
+2 -2
View File
@@ -1,2 +1,2 @@
VERSION_NAME=1.0.24 VERSION_NAME=1.0.30
VERSION_CODE=25 VERSION_CODE=31